Hip integration test #1031
Open
Hip integration test #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Larb-YasmineBadrElhouda
force-pushed
the
hip-integration-test
branch
from
a284198 to
5d06329
Compare
niermann999
reviewed
Aug 5, 2025
|
|
||
| // Covfie include(s) | ||
|
|
||
| // we can include it after solving the linking problem - covfie::hip in the cake |
Collaborator
There was a problem hiding this comment.
Suggested change
| // we can include it after solving the linking problem - covfie::hip in the cake | |
| // we can include it after solving the linking problem - covfie::hip in the cmake |
| // run the test code to copy the objects | ||
| detector_test(toy_det_data, volumes_data, surfaces_data, transforms_data, | ||
| rectangles_data, discs_data, cylinders_data); | ||
|
|
Collaborator
There was a problem hiding this comment.
Let's not change this file unless we need to
Collaborator
|
Could we maybe put the covfie update in a separate PR? |
Larb-YasmineBadrElhouda
force-pushed
the
hip-integration-test
branch
from
e81b934 to
9e9e586
Compare
niermann999
reviewed
Aug 12, 2025
|
|
||
| # C++17 support for HIP requires CMake 3.21. | ||
| cmake_minimum_required(VERSION 3.21) # HIP langauge support requires minimum 3.21 | ||
|
|
Collaborator
There was a problem hiding this comment.
Do we really need the detray_test_hip library for the propagator integration test?
| // run the test code to copy the objects | ||
| detector_test(toy_det_data, volumes_data, surfaces_data, transforms_data, | ||
| rectangles_data, discs_data, cylinders_data); | ||
|
|
Collaborator
There was a problem hiding this comment.
Please revert the changes in this file
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of the HIP integration test : CMake config + propagator test